Fix Uc gate global phase #8231
Merged
Fix Uc gate global phase #8231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2664213723
💛 - Coveralls |
Closed
mtreinish
added
stable backport potential
HuangJunye
added
the
Community PR
ewinston
reviewed
Jun 28, 2022
ewinston
reviewed
Jun 28, 2022
| @@ -73,6 +72,8 @@ def __init__(self, isometry, num_ancillas_zero, num_ancillas_dirty, epsilon=_EPS | |||
| if len(isometry.shape) == 1: | |||
| isometry = isometry.reshape(isometry.shape[0], 1) | |||
|
|
|||
| self.iso_data = np.array(isometry) | |||
There was a problem hiding this comment.
I don't believe it's necessary for this object to carry two copies of isometry; here and in self.params[0]. Also, the object should already be an ndarray.
ewinston
reviewed
Jun 30, 2022
ewinston
approved these changes
Jul 13, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
* global phase UCGate * Create global-phase-ucgate-cd61355e314a3e64.yaml * Update qiskit/extensions/quantum_initializer/isometry.py * Update qiskit/extensions/quantum_initializer/isometry.py Co-authored-by: ewinston <ewinston@us.ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit f2c2fe2)
mergify bot
added a commit
that referenced
this pull request
Jul 19, 2022
* global phase UCGate * Create global-phase-ucgate-cd61355e314a3e64.yaml * Update qiskit/extensions/quantum_initializer/isometry.py * Update qiskit/extensions/quantum_initializer/isometry.py Co-authored-by: ewinston <ewinston@us.ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit f2c2fe2) Co-authored-by: Adenilton Silva <7927558+adjs@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
hhorii
added a commit
to hhorii/qiskit-terra
that referenced
this pull request
Aug 4, 2022
hhorii
added a commit
to hhorii/qiskit-terra
that referenced
this pull request
Aug 4, 2022
hhorii
added a commit
to hhorii/qiskit-terra
that referenced
this pull request
Aug 5, 2022
hhorii
added a commit
to hhorii/qiskit-terra
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the UCGate global phase and replaces PR #6226